Skip to content

WIP: 🌱 feat: secrets manager sdk v2 changes #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: 🌱 feat: secrets manager sdk v2 changes #5614

wants to merge 1 commit into from

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind support

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/support Categorizes issue or PR as a support question. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ankitasw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cnmcavoy and faiq August 8, 2025 17:20
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 8, 2025
@richardcase richardcase changed the title WIP: 🌱wip: secrets manager sdk v2 changes WIP: 🌱 feat: secrets manager sdk v2 changes Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

@richardcase: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-test f9d702f link true /test pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-apidiff-main f9d702f link false /test pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build-docker f9d702f link true /test pull-cluster-api-provider-aws-build-docker
pull-cluster-api-provider-aws-e2e-blocking f9d702f link true /test pull-cluster-api-provider-aws-e2e-blocking
pull-cluster-api-provider-aws-build f9d702f link true /test pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-verify f9d702f link true /test pull-cluster-api-provider-aws-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@richardcase
Copy link
Member Author

@damdo @nrb - this is a PR with what i had so far. I started and didn't have time to carry it on due to work. Feel free to push to the branch (i have added you both). Or if its easier just ignore this PR :)

@shellyyang1989
Copy link

cc @LiangquanLi930

@LiangquanLi930
Copy link

I can continue working on this PR.

@shellyyang1989
Copy link

Thanks @LiangquanLi930 for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@faiq faiq Awaiting requested review from faiq

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/support Categorizes issue or PR as a support question. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardcase @k8s-ci-robot @shellyyang1989 @LiangquanLi930